Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): verify pepr can be deployed with zarf #1531

Merged
merged 22 commits into from
Dec 6, 2024

Conversation

samayer12
Copy link
Collaborator

Description

This PR adds a test to ensure pepr can be deployed with zarf.

Related Issue

Fixes #1516

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@samayer12 samayer12 requested a review from a team as a code owner December 6, 2024 18:33
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (921b0b4) to head (584134d).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1531   +/-   ##
=======================================
  Coverage   78.97%   78.97%           
=======================================
  Files          40       40           
  Lines        1736     1736           
  Branches      388      414   +26     
=======================================
  Hits         1371     1371           
+ Misses        363      335   -28     
- Partials        2       30   +28     

see 7 files with indirect coverage changes

@samayer12 samayer12 changed the title 1516-e2e-zarf-config chore(testing): verify pepr can be deployed with zarf Dec 6, 2024
@samayer12 samayer12 force-pushed the 1516-e2e-zarf-config branch from 4290363 to 06c87c4 Compare December 6, 2024 18:54
@samayer12 samayer12 force-pushed the 1516-e2e-zarf-config branch 2 times, most recently from 9389419 to 31b02f9 Compare December 6, 2024 19:03
@samayer12 samayer12 force-pushed the 1516-e2e-zarf-config branch from 31b02f9 to f60172f Compare December 6, 2024 19:05
@samayer12 samayer12 force-pushed the 1516-e2e-zarf-config branch from f204093 to 3fd0995 Compare December 6, 2024 19:16
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! lgtm

@cmwylie19 cmwylie19 added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 35bf589 Dec 6, 2024
48 checks passed
@cmwylie19 cmwylie19 deleted the 1516-e2e-zarf-config branch December 6, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

e2e test for zarf config
2 participants