chore: refactor complex implementation of request-processing filters #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
+ Coverage 78.02% 79.36% +1.34%
==========================================
Files 35 38 +3
Lines 1670 1793 +123
Branches 371 363 -8
==========================================
+ Hits 1303 1423 +120
- Misses 365 368 +3
Partials 2 2
|
|
To troubleshoot CI issues locally, download the controller and image artifact from build. |
cmwylie19
approved these changes
Oct 30, 2024
samayer12
added a commit
that referenced
this pull request
Nov 6, 2024
5 tasks
cmwylie19
pushed a commit
that referenced
this pull request
Nov 6, 2024
## Description Reverts filter-chaining from #1333 due to regressions, but keeps subsequent work. End to End Test: <!-- if applicable --> (See [Pepr Excellent Examples](https://github.com/defenseunicorns/pepr-excellent-examples)) ## Related Issue Relates to #1248 Closes #1389 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
… processing (#1402) ## Description The adjudicators are untyped, which caused complications when merging PR #1333. We should use TypeScript to enforce typing so that any refactors to filtering are based upon a solid foundation that does not require intermediate kludges with the typing system. End to End Test: <!-- if applicable --> (See [Pepr Excellent Examples](https://github.com/defenseunicorns/pepr-excellent-examples)) ## Related Issue Relates to #1248, #1406, #1407, #1408, #1409, #1397 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Case Wylie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of the effort to reduce complexity in the code. Instead of using ternaries that are chained together, this refactor introduces a FilterChain analagous to what you might see in the Spring Framework to achieve the same outcome, improving readability and maintenance.
Related Issue
Relates to #1248
Type of change
Checklist before merging