Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: src/lib/assets/index.ts #1495

Closed
btlghrants opened this issue Dec 3, 2024 · 1 comment
Closed

refactor: src/lib/assets/index.ts #1495

btlghrants opened this issue Dec 3, 2024 · 1 comment
Assignees
@btlghrants
Labels
tech-debt
Milestone
v0.42.0

Comments

@btlghrants
Copy link
Collaborator

Describe what should be investigated or refactored

Refactor of src/lib/assets/index.ts to reduce complexity warnings:

/pepr/src/lib/assets/index.ts
  82:23  warning  Async method 'generateHelmChart' has a complexity of 12. Maximum allowed is 10        complexity
  82:23  warning  Async method 'generateHelmChart' has too many statements (58). Maximum allowed is 20  max-statements

Additional context

In support of #1248
@btlghrants btlghrants converted this from a draft issue Dec 3, 2024
@btlghrants btlghrants self-assigned this Dec 3, 2024
@btlghrants btlghrants added this to the v0.41.0 milestone Dec 3, 2024
@btlghrants btlghrants changed the title refactor: src/lib/controller/index.ts refactor: src/lib/assets/index.ts Dec 3, 2024
@btlghrants
Copy link
Collaborator Author

Closing issue as "extra" - just going to PR under #1248 directly.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Pepr Project Board Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btlghrants btlghrants

Labels
tech-debt
Projects
None yet
Milestone
v0.42.0
Development

No branches or pull requests
1 participant
@btlghrants