Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): translation #1046

Merged
merged 22 commits into from
Sep 20, 2024
Merged

feat(ui): translation #1046

merged 22 commits into from
Sep 20, 2024

Conversation

andrewrisse
Copy link
Contributor

@andrewrisse andrewrisse commented Sep 17, 2024

Description

Adds translation ability to UI for audio files
LeapfrogAI - Chat - 19 September 2024 - Watch Video

BREAKING CHANGES

CHANGES

Previously, our file upload for chat completion (chat w/o assistant) used a form to submit the files to a SvelteKit form action. When trying to use the form data in another component for audio files, it became complicated and messy. I refactored the file upload to use an API endpoint instead of the form action, which required some refactoring in various places. The logic is cleaner now and will make our next stories (transcription and summarization) easier. Most of the functionality was moved into api/files/parse-text, but some moved out to the ChatFileUpload.svelte component as well.
ChatFileUploadForm.svelte was renamed ChatFileUpload for this.
src/leapfrogai_ui/src/routes/chat/(dashboard)/[[thread_id]]/+page.server.ts was deleted.

I've created two chores that will depend on this story being merged:
#1051
#1056

Related Issue

Closes #1040

Checklist before merging

@andrewrisse andrewrisse added the enhancement New feature or request label Sep 17, 2024
@andrewrisse andrewrisse self-assigned this Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit 68da3cd
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66ec8f49e49bb90008914648

@andrewrisse andrewrisse marked this pull request as ready for review September 18, 2024 15:58
@andrewrisse andrewrisse requested a review from a team as a code owner September 18, 2024 15:58
@andrewrisse andrewrisse marked this pull request as draft September 19, 2024 20:22
@andrewrisse andrewrisse marked this pull request as ready for review September 19, 2024 21:20
Copy link
Contributor

@gregclark-defenseunicorns gregclark-defenseunicorns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design review passed after the minor ui tweaks to the scroll buttons

@andrewrisse andrewrisse merged commit d954c33 into main Sep 20, 2024
24 checks passed
@andrewrisse andrewrisse deleted the translation branch September 20, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ui) Translation of Audio Files in Chat Thread
3 participants