-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): translation #1046
Merged
Merged
feat(ui): translation #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrisse
requested review from
CollectiveUnicorn and
gregclark-defenseunicorns
September 17, 2024 22:35
✅ Deploy Preview for leapfrogai-docs canceled.
|
This was referenced Sep 18, 2024
gregclark-defenseunicorns
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design review passed after the minor ui tweaks to the scroll buttons
CollectiveUnicorn
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds translation ability to UI for audio files
LeapfrogAI - Chat - 19 September 2024 - Watch Video
BREAKING CHANGES
CHANGES
Previously, our file upload for chat completion (chat w/o assistant) used a form to submit the files to a SvelteKit form action. When trying to use the form data in another component for audio files, it became complicated and messy. I refactored the file upload to use an API endpoint instead of the form action, which required some refactoring in various places. The logic is cleaner now and will make our next stories (transcription and summarization) easier. Most of the functionality was moved into api/files/parse-text, but some moved out to the ChatFileUpload.svelte component as well.
ChatFileUploadForm.svelte was renamed ChatFileUpload for this.
src/leapfrogai_ui/src/routes/chat/(dashboard)/[[thread_id]]/+page.server.ts was deleted.
I've created two chores that will depend on this story being merged:
#1051
#1056
Related Issue
Closes #1040
Checklist before merging