-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split up make clean target #1029
Conversation
✅ Deploy Preview for leapfrogai-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick that technically doesn't need to be here - can we include a UDS clean too?
This works on Debian based distros, but the temp files may be located elsewhere in Mac and Windows. The temp files do take up a TON of space if your OS clean-up job isn't often or thorough.
uds zarf tools clear-cache && rm -rf ~/.uds-cache && rm -rf /tmp/zarf-*
@justinthelaw I don't disagree that this is a valuable alias. My only concern with adding another make target to this PR is that it would exceed the scope of LeapfrogAI by hitting system level zarf/uds caches. By limiting our cleanup to files within this directory we avoid that. We have PS: I need a rereview anyway due to a typo. |
Description
Splitting up some of the make targets for cleaning up artifacts, cache, etc. This will help when the intent is only delete build artifacts or models, without also hitting .env or ruff_cache.
BREAKING CHANGES
None
CHANGES
make clean
with an include formk-clean.mk
make clean
functionality intoclean-artifacts
,clean-cache
,clean-env
,clean-models
, andclean-logs
make clean-all
to replicate previous functionality.Related Issue
None, just an problem spotted in the course of rebuilding.
Checklist before merging