Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): html/markdown security #1006

Merged
merged 15 commits into from
Sep 16, 2024
Merged

chore(ui): html/markdown security #1006

merged 15 commits into from
Sep 16, 2024

Conversation

andrewrisse
Copy link
Contributor

@andrewrisse andrewrisse commented Sep 6, 2024 •
edited by justinthelaw
Loading

Description

Updates the order of sanitization of text rendered in messages to improve security.

Checklist before merging

@andrewrisse andrewrisse self-assigned this Sep 6, 2024
@andrewrisse andrewrisse marked this pull request as ready for review September 6, 2024 21:24
@andrewrisse andrewrisse requested a review from a team as a code owner September 6, 2024 21:24
@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit 02a4262
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66e1d9bac056290009fc6dc1

@andrewrisse andrewrisse requested a review from bburky September 10, 2024 21:18
bburky
bburky previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@bburky bburky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only really reviewed src/leapfrogai_ui/src/lib/components/Message.svelte, but the change looks good to me.

I'll review CodeBlock comprehensively sometime in the future, but if that extra sanitization doesn't break anything, that's good to add.

justinthelaw
justinthelaw previously approved these changes Sep 10, 2024
View reviewed changes
@andrewrisse andrewrisse dismissed stale reviews from justinthelaw and bburky via c5ad2d9 September 11, 2024 16:58
@andrewrisse andrewrisse merged commit 6a0038a into main Sep 16, 2024
20 checks passed
@andrewrisse andrewrisse deleted the html-security branch September 16, 2024 14:18
@github-actions github-actions bot mentioned this pull request Sep 16, 2024
Merged
@andrewrisse andrewrisse mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gphorvath gphorvath gphorvath approved these changes

@justinthelaw justinthelaw justinthelaw left review comments

@bburky bburky bburky left review comments

@jalling97 jalling97 Awaiting requested review from jalling97

Assignees

@andrewrisse andrewrisse

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewrisse @bburky @gphorvath @justinthelaw