-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): fix and re-activate integration and unit tests #1004
chore(test): fix and re-activate integration and unit tests #1004
Conversation
✅ Deploy Preview for leapfrogai-docs canceled.
|
…backend-integration-test-for-pr-995
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the integration tests be a part of the pipeline is fantastic!
Just pointing out though that the pytest
workflow takes about 25 minutes now, which is about as long as it takes to test text-embeddings
. So while we're not taking any longer to run all of the tests, we're further cementing that 25-30 minute timeframe. If we make changes in the future to futher optimize the E2E tests, addressing the integration tests will probably also be necessary.
@jalling97 totally agree! I will make an evergreen spike to investigate speeding up all e2e tests, including integration tests. The difficulty is definitely that each backend is very time-consuming to install and build. What we can do in the spike is investigate GH caching (like I do with the pip deps) and also more usage of a no/low-weight model like the repeater or T5, GPT2 etc., in tests-only. |
Description
See PR #994 for details on testing issues, and #564 for the overall integration testing issues. If the integration tests were run prior to committing, or in the pipeline, the
file_ids
issue fixed by PR #994 (related to Issue #1001) would have been caught earlier.BREAKING CHANGES
CHANGES
unstructured
andnltk
versions to allow for.pptx
chunking, which was previously not working and failed integration testsRelated Issue
Fixes Issues #1001 #564
Related to PR #994
Checklist before merging