Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: Cloudtrail #177

Merged
merged 6 commits into from
Apr 20, 2023
Merged

New module: Cloudtrail #177

merged 6 commits into from
Apr 20, 2023

Conversation

RothAndrew
Copy link
Member

@RothAndrew RothAndrew commented Apr 17, 2023

Changes

  • Introduces a new module for creating a CloudTrail and removes the creation of a CloudTrail from the Bastion module
  • Some other misc small refactors
  • Intentionally does NOT create a cloudtrail in the examples/complete root module, due to the hard limit of 5 cloudtrails per region. The CloudTrail module has its own examples/complete folder with a root module that creates a cloudtrail. This module is NOT included in this repo's automated testing. This is setting up the module for being extracted to its own repo, where it will have an automated testing pipeline that runs when changes are made to it.

Closes #164

@RothAndrew RothAndrew marked this pull request as ready for review April 19, 2023 19:50
@RothAndrew RothAndrew requested review from a team as code owners April 19, 2023 19:50
Copy link
Contributor

@brianrexrode brianrexrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ntwkninja
Copy link
Member

🙌 🚀

@RothAndrew RothAndrew enabled auto-merge (squash) April 20, 2023 15:04
@RothAndrew RothAndrew merged commit 2ce4388 into main Apr 20, 2023
@RothAndrew RothAndrew deleted the feature/cloudtrail branch April 20, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Externalize and centralize the CloudTrail
3 participants