This repository has been archived by the owner on Jul 8, 2023. It is now read-only.
debounce-handler: invoke actual function from component props #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user1736
force-pushed
the
feat/dynamic-prop-debouncing
branch
from
c2fa59d
to
f0e193a
Compare
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 17 17
Lines 238 239 +1
=====================================
+ Hits 238 239 +1
Continue to review full report at Codecov.
|
|
Thanks, I'll take a look. |
|
Do you mind adding an additional test for that? |
|
Sure, I will do it this week |
user1736
force-pushed
the
feat/dynamic-prop-debouncing
branch
from
213922a
to
a33ebb7
Compare
user1736
force-pushed
the
feat/dynamic-prop-debouncing
branch
from
a33ebb7
to
9d31b54
Compare
|
@deepsweet I added the tests, could you please have a look at it? |
deepsweet
changed the title
|
Thanks! Just landed with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Not sure if it's designed behaviour or just a bug, but current implementation of
debounceHandlerdoesn't pick updates from props. As a result, if during wrapped component lifetime parent component decide to pass a new version of the handler function, wrapped component won't receive it and will continue using initial version of the handler.Here's the short demo of the problem.