Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that there are no race conditions in REST API /query endpoint #3914

Closed
Tracked by #3755
bogdankostic opened this issue Jan 23, 2023 · 2 comments
Closed
Tracked by #3755
Labels
P2 Medium priority, add to the next sprint if no P1 available topic:rest_api

Comments

@bogdankostic
Copy link
Contributor

The REST API can run multiple request concurrently by setting CONCURRENT_REQUEST_PER_WORKER. For concurrent requests, it’s important that we don’t have any race conditions inside the application to ensure the responses are correct. Let’s check our REST API thoroughly for race conditions.

@mayankjobanputra
Copy link
Contributor

  1. Uvicorn has worker settings for parallel requests; use it and get rid of our concurrency_limiter
  2. Talk about REST API unit tests with Massi

@mayankjobanputra mayankjobanputra changed the title Ensure that there are no race conditions in REST API Ensure that there are no race conditions in REST API /query endpoint Jan 31, 2023
@bogdankostic bogdankostic self-assigned this Apr 12, 2023
@masci masci added P2 Medium priority, add to the next sprint if no P1 available and removed P1 High priority, add to the next sprint labels May 10, 2023
@masci
Copy link
Contributor

masci commented Sep 26, 2023

We plan to rewrite the rest api and move to async pipeline execution, let's not invest time here

@masci masci closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority, add to the next sprint if no P1 available topic:rest_api
Projects
None yet
Development

No branches or pull requests

3 participants