-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Training and evaluation for MultiModalRetriever
#3410
Comments
@ZanSara this proposal sounds very interesting and challenging! If you would like to provide some resources/pointers/examples to get started with the implementation, I think that they would be very helpful for me and the other contributors 😃. Do you think that this dataset could be useful to test the implementation or do you have better proposals? |
Hey @anakin87! Nice one you've picked! So I should make a premise: I'm not the most knowledgeable in the team about evaluation and training of models, so take my input with a grain of salt 😄 That said:
Have fun with this one 😁 Also, please open separate PRs for the different features in order to keep them small. |
I was thinking about CLIP training/fine-tuning...At the moment, I'm sure that even if not available out-of-the-box, the training/fine-tuning can be done using Transformers or other approaches (openai/CLIP#150). ...but there is much more in this issueStudying a bit the So I wonder: is there a unified and effective way to perform the training in such a heterogeneous set of situations? To give a more focused scope to this issue, I'm curious to hear your opinions: @ZanSara @bogdankostic @julian-risch @vblagoje @mayankjobanputra... |
@anakin87 my hunch, without proper investigation, is that training/fine-tuning such a model should be outside of Haystack's scope. These models are fine-tuned using accelerate/hf library setup, and I am hard-pressed to see a reason for adding such support in Haystack. |
@vblagoje I originally added this issue for consistency with other Retrievers: if you see this unfeasible, let's skip 👍 However, I believe evaluation is still valuable and should be implemented. WDYT? |
@ZanSara I am not sure, tbh. I would say it is prudent to keep the eval interface we already have as they seem to be more consistent than training APIs. Something we can talk about internally first as well. |
Very broad topic; training is not a focus currently. |
Currently there's no
train()
oreval()
methods forMultiModalRetriever
.We should add them, taking inspiration from
EmbeddingRetriever
.The text was updated successfully, but these errors were encountered: