Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Langfuse Integration: start/end time of generators are not logged #1262

Open
marcklingen opened this issue Dec 24, 2024 · 2 comments · May be fixed by #1301
Open

Langfuse Integration: start/end time of generators are not logged #1262

marcklingen opened this issue Dec 24, 2024 · 2 comments · May be fixed by #1301
Labels
bug Something isn't working integration:langfuse P1

Comments

@marcklingen
Copy link
Contributor

marcklingen commented Dec 24, 2024 •
edited
Loading

Describe the bug

While this works for non-LLM/generator nodes, generator nodes do not log start/end times to Langfuse.

Example trace: https://cloud.langfuse.com/project/cloramnkj0002jz088vzn1ja4/traces/42cb3022-b114-4e33-b8c7-774229d451b6?observation=9326286a-fdd4-4f12-8fe0-b22e480df767&display=details

To Reproduce

https://github.com/langfuse/langfuse-docs/blob/main/cookbook/integration_haystack.ipynb

Describe your environment (please complete the following information):

Colab with latest packages, see above.
@marcklingen marcklingen added the bug Something isn't working label Dec 24, 2024
@vblagoje
Copy link
Member

Thanks for logging this bug, @marcklingen. Just to confirm: once this bug is fixed, the Langfuse web UI will show how long it took to generate the response—similar to the other components in the screenshot, right?
Image

@marcklingen
Copy link
Contributor Author

That's correct @vblagoje! This currently works for all components except for LLM/generator nodes

@vblagoje vblagoje linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working integration:langfuse P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: End langfuse generation spans properly deepset-ai/haystack-core-integrations
3 participants
@vblagoje @marcklingen @julian-risch