Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support system available lammps #4376

Open
ccoulombe opened this issue Nov 18, 2024 · 5 comments
Open

[Feature Request] Support system available lammps #4376

ccoulombe opened this issue Nov 18, 2024 · 5 comments

Comments

@ccoulombe
Copy link

Summary

On HPC clusters, highly optimized softwares are most often already available. Allow deepmd-kit to build and link to an already available and correctly configured lammps.

Detailed Description

Software is already available on numerous systems, allow one to build deepmd-kit with already optimized available lammps and not try to download or build it from sources.

If one defines LAMMPS_ROOT, for example, then prefer it to building from sources.

Further Information, Files, and Links

No response

@njzjz
Copy link
Member

njzjz commented Nov 18, 2024

There is the CMake option LAMMPS_SOURCE_ROOT to build a LAMMPS plugin.

For details of the plugin mode, refer to LAMMPS documentation Compiling plugins and plugin command.

@ccoulombe
Copy link
Author

Yes, I did try to use it, but it needs a source tree, rather then an already built and available lammps installation.

For example, this

says that the src needs to exists, but on an installed lammps, it does not, nor contains the source files.

Our system and optimized lammps is already built with the correct settings.

That's is why it would be great if one could link on an already available installation rather then to compile one.

@njzjz
Copy link
Member

njzjz commented Nov 18, 2024

Unlike other libraries, LAMMPS doesn't install header files required by the plugin into the system.

@ccoulombe
Copy link
Author

ccoulombe commented Nov 19, 2024 via email

@njzjz
Copy link
Member

njzjz commented Nov 19, 2024

#include "lammpsplugin.h"

#include "atom.h"
#include "citeme.h"
#include "comm.h"
#include "compute.h"
#include "domain.h"
#include "error.h"
#include "fix.h"
#include "force.h"
#include "memory.h"
#include "modify.h"
#include "neigh_list.h"
#include "neigh_request.h"
#include "neighbor.h"
#include "output.h"
#include "update.h"

#include "atom.h"
#include "domain.h"
#include "error.h"
#include "force.h"
#if LAMMPS_VERSION_NUMBER >= 20221222
#include "grid3d.h"
#else
#include "gridcomm.h"
#endif
#include "math_const.h"
#include "memory.h"
#include "pppm.h"

#include "atom.h"
#include "comm.h"
#include "domain.h"
#include "error.h"
#include "fix.h"
#include "force.h"
#include "memory.h"
#include "modify.h"
#include "neigh_list.h"
#include "neigh_request.h"
#include "neighbor.h"
#include "pair.h"
#include "update.h"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants