Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add universal/consistent tests for loss modules #4105

Open
njzjz opened this issue Sep 5, 2024 · 1 comment · Fixed by #4354
Open

Add universal/consistent tests for loss modules #4105

njzjz opened this issue Sep 5, 2024 · 1 comment · Fixed by #4354
Assignees
Milestone

Comments

@njzjz
Copy link
Member

njzjz commented Sep 5, 2024

+ Hits        42870    43087     +217     
- Misses       7822     7934     +112     
- Partials      946      948       +2     

I see that 1/3 of the new codes have not been tested.

Where can I see these datas about missing UT? I will add UT based on these datas.

You can click the link sent by @codecov or click the codecov checks.

It looks like the loss module is not tested. @iProzd Do we have a universal test fixture for loss functions?

Not yet, maybe we need a discussion to design a universal test for loss modules.

Originally posted by @iProzd in #3867 (comment)

@njzjz njzjz changed the title Add universal test for loss modules Add universal/consistent tests for loss modules Sep 5, 2024
@iProzd iProzd self-assigned this Sep 26, 2024
@iProzd iProzd moved this to mustfix in DeePMD-kit V3.0.0 RC Sep 26, 2024
@njzjz njzjz added this to the v3.0.0 milestone Sep 26, 2024
@njzjz njzjz linked a pull request Nov 13, 2024 that will close this issue
@njzjz
Copy link
Member Author

njzjz commented Nov 15, 2024

Now we have the universal tests but not the consistent tests.

@njzjz njzjz modified the milestones: v3.0.0, v3.1.0 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: mustfix
Development

Successfully merging a pull request may close this issue.

2 participants