Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and Examples #5

Closed
joaogui1 opened this issue Mar 8, 2020 · 11 comments
Closed

Documentation and Examples #5

joaogui1 opened this issue Mar 8, 2020 · 11 comments

Comments

@joaogui1
Copy link
Contributor

joaogui1 commented Mar 8, 2020

So, are you guys planning on releasing the documentation and adding more examples? It's kind of hard to understand what the library has to offer and how to use it right now

@joaogui1
Copy link
Contributor Author

Pinging @chris-chris @tomhennigan

@mtthss
Copy link
Collaborator

mtthss commented Mar 20, 2020

Hi, thanks for the comment.
We indeed plan to release more examples and add more extensive documentation.

@chris-chris
Copy link
Contributor

@joaogui1 @mtthss
I'm implementing more examples using rlax and haiku step by step.
currently working on A3C :)

@aslanides
Copy link
Member

We currently have two example agents using Haiku & rlax in bsuite baselines.

@joaogui1
Copy link
Contributor Author

joaogui1 commented Apr 4, 2020

Maybe you could copy them here or reference them in the README?

@aslanides
Copy link
Member

@joaogui1
Copy link
Contributor Author

joaogui1 commented Apr 7, 2020

I had already seen it, my suggestion is more about helping other people interested in the library who won't check all repos that depend on it

@joaogui1
Copy link
Contributor Author

joaogui1 commented Apr 22, 2020

I wrote this example here: DQN
It uses the double q learning function, shows how to use vmap with your loss and implements a experience buffer.
What do you guys be interested in adding it to examples?

@mtthss
Copy link
Collaborator

mtthss commented Apr 23, 2020

Hello @joaogui1 ,

  • I added to the README a link to the bsuite examples, thanks for the suggestion!
  • Will take a look at your proposed DQN next and get back to you tomorrow.

@mtthss
Copy link
Collaborator

mtthss commented Apr 24, 2020

Hello @joaogui1 ,
The DQN example would be a nice contribution!
If you put together a PR, we can discuss the details there?

@joaogui1 joaogui1 mentioned this issue Apr 25, 2020
@mtthss
Copy link
Collaborator

mtthss commented May 1, 2020

Thanks @joaogui1 for the contribution!

We now have fully worked online Qlearning and DQN agents, plus references in the README to several BSuite agents that use rlax.

@mtthss mtthss closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants