Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Spectrum Theme for Missing ContextualHelpTrigger Icon #2330

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgodinez-dh
Copy link
Contributor

This is for ui.menu
https://deephaven.atlassian.net/browse/DH-18089
The ContexualHelpTrigger icon does not display because incorrect box-sizing.

@dgodinez-dh dgodinez-dh requested a review from dsmmcken January 6, 2025 19:14
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.71%. Comparing base (3608b15) to head (5dc65ff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2330   +/-   ##
=======================================
  Coverage   46.71%   46.71%           
=======================================
  Files         704      704           
  Lines       39031    39031           
  Branches     9752     9752           
=======================================
  Hits        18234    18234           
  Misses      20786    20786           
  Partials       11       11           
Flag Coverage Δ
unit 46.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed changed the title fix: Update Spectrum Them for Missing ContextualHelpTrigger Icon fix: Update Spectrum Theme for Missing ContextualHelpTrigger Icon Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant