We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description
There are a couple of issues with the current styling of the ErrorBoundary, namely:
a. If we are to throw from certain files, ie. ReactPanel.tsx, we observe that the icon and the message are not centered in the output panel
ReactPanel.tsx
b. If we shrink the output panel to be really small, the error icon sometimes breaks out of the window.
Steps to reproduce
For non-centered issue:
from deephaven import ui testP = ui.panel(ui.panel("Nested panel"))
For icon-breaking out issue:
Expected results
The icon and message should always be centered in the output window, and regardless of size, the icon should not break out of the output window.
Actual results
Refer to description
Additional details and attachments
In SS below, icon and message are not centered:
In SS below, after making output panel very small, the icon breaks out
Versions
Engine Version: 0.36.0-SNAPSHOT Web UI Version: 0.86.0 Java Version: 21.0.3 Barrage Version: 0.6.0 Browser Name: Chrome 126 OS Name: macOS 10.15.7 @deephaven/js-plugin-ui: 0.18.0 @deephaven/js-plugin-matplotlib: 0.4.1 @deephaven/js-plugin-plotly-express: 0.11.0
The text was updated successfully, but these errors were encountered:
d2ec9ed
AkshatJawne
Successfully merging a pull request may close this issue.
Description
There are a couple of issues with the current styling of the ErrorBoundary, namely:
a. If we are to throw from certain files, ie.
ReactPanel.tsx
, we observe that the icon and the message are not centered in the output panelb. If we shrink the output panel to be really small, the error icon sometimes breaks out of the window.
Steps to reproduce
For non-centered issue:
ReactPanel.tsx
)For icon-breaking out issue:
Expected results
The icon and message should always be centered in the output window, and regardless of size, the icon should not break out of the output window.
Actual results
Refer to description
Additional details and attachments
In SS below, icon and message are not centered:
In SS below, after making output panel very small, the icon breaks out
Versions
Engine Version: 0.36.0-SNAPSHOT
Web UI Version: 0.86.0
Java Version: 21.0.3
Barrage Version: 0.6.0
Browser Name: Chrome 126
OS Name: macOS 10.15.7
@deephaven/js-plugin-ui: 0.18.0
@deephaven/js-plugin-matplotlib: 0.4.1
@deephaven/js-plugin-plotly-express: 0.11.0
The text was updated successfully, but these errors were encountered: