Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorBoundary Styling Issues #642

Closed
AkshatJawne opened this issue Jul 18, 2024 · 0 comments · Fixed by #669
Closed

ErrorBoundary Styling Issues #642

AkshatJawne opened this issue Jul 18, 2024 · 0 comments · Fixed by #669
Assignees
Labels
bug Something isn't working
Milestone

Comments

@AkshatJawne
Copy link
Contributor

AkshatJawne commented Jul 18, 2024

Description

There are a couple of issues with the current styling of the ErrorBoundary, namely:

a. If we are to throw from certain files, ie. ReactPanel.tsx, we observe that the icon and the message are not centered in the output panel

b. If we shrink the output panel to be really small, the error icon sometimes breaks out of the window.

Steps to reproduce

For non-centered issue:

  1. Run the following snippet (assuming changes in fix: invalid ui.panel usage should result in clear error #641, where we throw from ReactPanel.tsx)
from deephaven import ui
 
testP = ui.panel(ui.panel("Nested panel"))

For icon-breaking out issue:

  1. Run the snippet above
  2. Make window incredibly short, like in SS below

Expected results

The icon and message should always be centered in the output window, and regardless of size, the icon should not break out of the output window.

Actual results

Refer to description

Additional details and attachments

In SS below, icon and message are not centered:
Screenshot 2024-07-18 at 10 32 52 AM

In SS below, after making output panel very small, the icon breaks out
Screenshot 2024-07-18 at 10 33 49 AM

Versions

Engine Version: 0.36.0-SNAPSHOT
Web UI Version: 0.86.0
Java Version: 21.0.3
Barrage Version: 0.6.0
Browser Name: Chrome 126
OS Name: macOS 10.15.7
@deephaven/js-plugin-ui: 0.18.0
@deephaven/js-plugin-matplotlib: 0.4.1
@deephaven/js-plugin-plotly-express: 0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants