Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine multiple formatRowWhere/format_row_where calls #5817

Closed
devonpallison opened this issue Jul 19, 2024 · 3 comments
Closed

Combine multiple formatRowWhere/format_row_where calls #5817

devonpallison opened this issue Jul 19, 2024 · 3 comments
Labels
feature request New feature or request triage

Comments

@devonpallison
Copy link
Contributor

As a user, I want to be able to call formatRowWhere more than once/have a method to pass in more than one condition/color pair so that I can easily color my rows using different conditions. For example:

from deephaven import empty_table t = empty_table(10).update(["X = i", "A = A"]) t2 = t.format_row_where("X % 2 == 0", "BLUE") t3 = t2.format_row_where("X % 2 == 1", "GREEN")

Wanted result: a table where rows alternate between blue and green.
Current result: a table where every other row is green, and the other rows are not formatted.

Possible bonus: apply the formats incrementally, with later calls taking precedent, e.g.

from deephaven import empty_table t = empty_table(10).update(["X = i", "A = A"]) t2 = t.format_row_where("X % 3 == 0", "BLUE") t3 = t2.format_row_where("X % 2 == 0", "GREEN")

Would result in some blue and green rows, with green overriding the blue when the condition is true for both.

@devonpallison devonpallison added feature request New feature or request triage labels Jul 19, 2024
@mofojed
Copy link
Member

mofojed commented Jul 19, 2024

We'll incorporate this into ui.table: deephaven/deephaven-plugins#596

@rcaudy
Copy link
Member

rcaudy commented Jul 19, 2024

I don't think we want to make further changes to this functionality. I anticipate that ui.table will address formatting use cases.

@rcaudy
Copy link
Member

rcaudy commented Jul 19, 2024

Never mind, Mike beat me to the comment.

@mofojed mofojed closed this as completed Jul 19, 2024
@rcaudy rcaudy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request triage
Projects
None yet
Development

No branches or pull requests

3 participants