Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pion/webrtc@v3 #64

Closed
Sean-Der opened this issue Jan 4, 2021 · 10 comments
Closed

Upgrade to pion/webrtc@v3 #64

Sean-Der opened this issue Jan 4, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Sean-Der
Copy link

Sean-Der commented Jan 4, 2021

Hey @deepch

I released v3 and would love to help you upgrade, I can make the PR. If you want to wait/have any questions happy to answer them.

API wise I this should make it a lot easier for users. The Track API has seen major changes. It handles the SSRC/PayloadType internally so you don't need to manage. It also enables Trickle ICE by default. You can disable it if you wish, but it could mean faster connect times.

@deepch
Copy link
Owner

deepch commented Jan 4, 2021

I tried using it but only got a black screen. Trickle ICE enables - and you can learn more about how to disable it

I will update the project to version pion v3 today.

@deepch deepch self-assigned this Jan 4, 2021
@Sean-Der
Copy link
Author

Sean-Der commented Jan 4, 2021

You can disable like this we provide GatheringCompletePromise

So it connects but you get a black screen? Maybe the codecs are configured wrong, the MediaEngine changes could be causing problems :( . If you can push to a branch would love to help debug!

@deepch
Copy link
Owner

deepch commented Jan 5, 2021

ready migrated worked on pion v3.
need test audio pcm

there is some kind of bug with timestamps.

https://github.com/deepch/vdk/blob/1b7359bceb450b427ac4c769ba35a35b5d4a5e79/format/webrtcv3/adapter.go#L161

I'll try to figure it out tomorrow, not very pretty yet, but overall it works.

@deepch deepch added the enhancement New feature or request label Jan 5, 2021
@Sean-Der
Copy link
Author

Sean-Der commented Jan 5, 2021

Nice! This is my timing code I used in rtsp-bench https://github.com/pion/rtsp-bench/blob/master/server/main.go#L175-L179

@deepch
Copy link
Owner

deepch commented Jan 5, 2021

Same result.

cur - pre = ts

Sample work only video track no audio.

https://github.com/pion/rtsp-bench/blob/dc315b35c4ed96f9c2921383beabd34b9135acd3/server/main.go#L160

Problem video + audio (pcm)

@deepch
Copy link
Owner

deepch commented Jan 5, 2021

I think it's a little thing tonight I'll do everything.

Thank you for your help!
good luck to you

@deepch deepch added the help wanted Extra attention is needed label Jan 6, 2021
@deepch deepch closed this as completed Jan 6, 2021
@AlexxIT
Copy link
Contributor

AlexxIT commented Jan 11, 2021

Hi @Sean-Der, you and @deepch doing great job!

Based on @deepch's project, I made a Home Assistant addon. Including working external access to users cameras. It already has many satisfied users. I think you would be pleased to know:

https://community.home-assistant.io/t/realtime-camera-streaming-without-any-delay-rtsp2webrtc/258216

@deepch
Copy link
Owner

deepch commented Jan 11, 2021

Hi @AlexxIT Great job. Continue in the same spirit.
It is very nice that you help people and a little later I will test your adon.

@deepch
Copy link
Owner

deepch commented Jan 11, 2021

@AlexxIT Вы можете писать и по русский я пойму ;)

@Sean-Der
Copy link
Author

That is so awesome! I posted on our Twitter :) https://mobile.twitter.com/_pion/status/1348845305693802503

you should also add to awesome-pion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants
@AlexxIT @Sean-Der @deepch and others