Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser level check unreliable? sleipnir, k-meleon, greenbrowser, slimbrowser, deepnet #73

Closed
lightbeard opened this issue Feb 7, 2015 · 1 comment
Milestone

Comments

@lightbeard
Copy link

sleipnir
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.95 Safari/537.36 Sleipnir/6.1.4

bowser.chrome     // true
bowser.version    // 39
bowser.a          // true

k-meleon
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20140105 Firefox/24.0 K-Meleon/74.0

bowser.firefox    // true
bowser.version    // 24
bowser.a          // true

greenbrowser
Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; InfoPath.2; GreenBrowser)

bowser.msie       // true
bowser.version    // 7
bowser.c          // true

deepnet
Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; InfoPath.2)

bowser.msie       // true
bowser.version    // 7
bowser.c          // true

slimbrowser
Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like Gecko

bowser.msie       // true
bowser.version    // 11
bowser.a          // true

Is bowser working as designed?

Basically we don't see how the browser level checks such as bowser.msie and boswer.firefox can be trusted at all.

@lancedikson
Copy link
Collaborator

@lightbeard, hey, good catch, thanks. We will add support for all of these browsers.

And yes, bowser is working as designed. We need support browser detection process manually. In most cases bowsers' assumptions are true, but sometimes there are special cases like those in the issue.

lancedikson added a commit that referenced this issue May 9, 2016
@lancedikson lancedikson added this to the 1.2.0 milestone May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants