Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CopyableText] extends compent class #299

Closed
fguisso opened this issue Oct 7, 2020 · 1 comment · Fixed by #382
Closed

[CopyableText] extends compent class #299

fguisso opened this issue Oct 7, 2020 · 1 comment · Fixed by #382

Comments

@fguisso
Copy link
Member

fguisso commented Oct 7, 2020

I'm using this component in the decrediton#2641 and I the style don't apply to child elements, my solution, seens not so good:

<CopyableText className={my_new_style}>testing</CopyableText>

.my_new_style span {
    ...
}

Maybe you can create somenthing like this:

<CopyableText spanStyle={my_new_span} buttonStyle={my_new_button_style} ...>testing</CopyableText>
@tiagoalvesdulce
Copy link
Member

We'll be implementing this since people can choose between both approaches. I personally prefer the first one since you can stick to CSS. The second one you have to write JS objects. We can add both spanStyle and spanClassName so we have all the options available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants