Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger: Broken on master. #3921

Closed
JoeGruffins opened this issue Oct 18, 2023 · 5 comments
Closed

Ledger: Broken on master. #3921

JoeGruffins opened this issue Oct 18, 2023 · 5 comments

Comments

@JoeGruffins
Copy link
Member

master is currently 391d8a5

Ledger needs WebUSB in order to work which is not supported by the current electron version. Please see the discussions in #3884

@JoeGruffins
Copy link
Member Author

JoeGruffins commented Oct 18, 2023

Can be closed by #3918

@xaur
Copy link
Contributor

xaur commented Oct 26, 2023

Can be closed by #3918

WebUSB is announced in Electron 23. Neither the blog nor the more detailed release notes mention WebUSB for Electron 22. Maybe it was added but not announced until v23? If WebUSB works in v22, that release is notable for being the last to support Windows 7.

@JoeGruffins
Copy link
Member Author

@xaur oh yeah I think you are correct. My mistake, we need 23+

@xaur
Copy link
Contributor

xaur commented Oct 27, 2023

Damn :) Ok we'll need to say Windows 7 is no longer supported too I think.

@JoeGruffins
Copy link
Member Author

closed by #3928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants