Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css modules] Add global style modules #2608

Closed
vctt94 opened this issue Jul 27, 2020 · 2 comments · Fixed by #3324
Closed

[css modules] Add global style modules #2608

vctt94 opened this issue Jul 27, 2020 · 2 comments · Fixed by #3324

Comments

@vctt94
Copy link
Member

vctt94 commented Jul 27, 2020

In decrediton we may have some styles which are the same for the whole application, for example, the class is-row which is used to describe a flex row around the code.

Rigth now if we need it with modules, we are adding isRow to many css modules, with the same code, which could be avoided if we have a shared global css modules, which are the same for many applications places.

@amass01
Copy link
Member

amass01 commented Jul 27, 2020

Make total sense, we need a main.css to replace main.less which can be used as plain classes without module hashing, and as @vctt94 mentioned can be used globally from any part of the app using string classes.

Usage would look something like:

className={classNames(styles.somthing, "classFromMainCss")}

@amass01
Copy link
Member

amass01 commented Mar 22, 2021

#3324 introduces main.css file for global styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants