Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Use consistent booleans in default config #2033

Closed
szpasztor opened this issue Feb 14, 2019 · 0 comments · Fixed by #2129
Closed

[refactor] Use consistent booleans in default config #2033

szpasztor opened this issue Feb 14, 2019 · 0 comments · Fixed by #2129

Comments

@szpasztor
Copy link
Contributor

The default global config sometimes uses the "true"/"false" string and sometimes a real JSON boolean type to represent booleans. It should always do the latter.

Autogenerated config:

{
	"theme": "theme-light",
	"daemon_start_advanced": false,
	"must_open_form": true,
	"locale": "en",
	"network": "mainnet",
	"set_language": "true",
	"ui_animations": true,
	"show_tutorial": "true",
	"show_privacy": true,
	"show_spvchoice": true,
	"allowed_external_requests": [],
	"proxy_type": null,
	"proxy_location": null,
	"remote_credentials": {
		"rpc_user": "",
		"rpc_password": "",
		"rpc_cert": "",
		"rpc_host": "",
		"rpc_port": ""
	},
	"appdata_path": "",
	"spv_mode": false,
	"spv_connect": [],
	"max_wallet_count": 3,
	"timezone": "local",
	"disable_hardware_accel": false
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants