Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indicator of node connection to peers #1030

Closed
matheusd opened this issue Dec 28, 2017 · 3 comments
Closed

Add indicator of node connection to peers #1030

matheusd opened this issue Dec 28, 2017 · 3 comments
Assignees

Comments

@matheusd
Copy link
Member

We're receiving a few support requests from people on spotty internet connections unable to perform functions (eg: purchasing a ticket or sending a transaction) or downloading block nodes. We need to add an indicator (visible both on the getstarted pages and on the main UI) for when peers are unreachable. This may or may not need work on dcrd/dcrwallet.

@matheusd
Copy link
Member Author

matheusd commented Jan 2, 2018

Dcrd has getconnectioncount/getpeerinfo rpc calls that can be used to collect the number of connected nodes of that dcrd instance, but dcrwallet currently doesn't expose that to decrediton.

Alternatives:

  1. Manually call that (like we call `getblockcount' on main.development)
  2. Add a getnetworkinfo (or something) call on dcrwallet that requests the info from the node and passes it back
  3. Add rpc connection directly to the node.

Alternative 1 is easiest, doesn't require modifying dcrd/dcrwallet but doesn't allow for notifications when connection is lost and is the worst option performance-wise (needs to start a dcrctl process each time we wanna check).

Alternative 2 implies work on dcrwallet but potentially allows notification and is possibly future-proof when we get SPV.

Alternative 3 implies work only on decrediton but is another connection/api to keep track of.

@alexlyp
Copy link
Member

alexlyp commented Jan 3, 2018

I believe @jrick and @davecgh have actively discussed solving this down below in dcrd/dcrwallet. When they land on a fix, we can then figure out a way to communicate with decrediton.

I'm mostly reticent about adding any further dcrctl calls as this will be need to be ripped out once we start to make decrediton ready for SPV (only comms with dcrwallet).

@jholdstock
Copy link
Member

I believe this can be closed as of #2685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants