Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5 rc1 Release Notes feedback #119

Closed
xaur opened this issue Nov 9, 2019 · 0 comments
Closed

v1.5 rc1 Release Notes feedback #119

xaur opened this issue Nov 9, 2019 · 0 comments

Comments

@xaur
Copy link
Contributor

xaur commented Nov 9, 2019

I submitted smaller fixes in #118. Below are things I couldn't figure out on my own.

dcrwallet v1.5.0-rc1

Arbitrary extended pubkeys can now be imported as a watching-only account,
even on wallets which do store private keys for other accounts.

decred/dcrwallet#1471 had "Addresses of imported xpub accounts are not watched and transactions are not saved.". If this is still the case, "watching-only" will cause confusion. Also, if it is still the case, I suggest adding this limitation to the release notes.

A --disablecointypeupgrades flag and config setting is added to prevent the
wallet from ever upgrading the coin type on a seed restored wallet, even when
there is no observed transactions for the seed.

Add a hint when this can be useful.

Deprecated config flags from the v1.4.0 release have been removed.

Please list them to save reader's time and quickly see if they need to update their config.

* A panic caused by out-of-bounds array access in the SPV syncer was identified
  and corrected.
dfdfdes zero confirmation
  transactions and corrects the `last_block` behavior to match bitcoind.

Buggy text.

decrediton v1.5.0-rc1

It also includes a preliminary Lightning Network implementation by matheusd. Most of the other work was completed by vctt and a new member of the team, bgptr. Many thanks to them for their hard work on this release.

I suggest to move credits to its own section at the end, similar to dcrd's Code Contributors. This is the first time I see credits in the intro.

Update Politeia proposal fetching to reduce amount of data that is consistantly
requested. Previously, every load of decrediton would cause an unnecessary
amount of data to be requested.

This is really a bug fix of an epic bug, should be under Bug fixes.

Update lockedByTickets balance to accomodate dcrwallet balance updates staking.

"balance updates staking" is hard to read, please reword.

General

  • inconsistent capitalization of Decrediton (vs decrediton) throughout the release notes
@alexlyp alexlyp closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants