Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check account vs db id during unlock #104

Closed
matheusd opened this issue Jun 17, 2020 · 0 comments · Fixed by #106
Closed

Check account vs db id during unlock #104

matheusd opened this issue Jun 17, 2020 · 0 comments · Fixed by #106

Comments

@matheusd
Copy link
Member

When using the remotedcrwallet driver, during the driver initialization it ensures the account being used is the same one as the previously used ones (specifically, here).

This check could (also) be done during the wallet unlock call of the WalletUnlocker service so that an error is synchronously returned to callers instead of waiting for the driver to start the init phanse and casuse the dcrlnd process to exit.

This would improve the UX in decrediton where we could capture this error more easily and present a better message than just time out connecting to dcrlnd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant