Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use decred's rpcclient for BTC with all requests going through RawRequest #841

Closed
chappjc opened this issue Nov 18, 2020 · 4 comments · Fixed by #938 or #975
Closed

use decred's rpcclient for BTC with all requests going through RawRequest #841

chappjc opened this issue Nov 18, 2020 · 4 comments · Fixed by #938 or #975
Assignees

Comments

@chappjc
Copy link
Member

chappjc commented Nov 18, 2020

btcsuite's rpcclient does not support request cancellation, so we might consider using decred's rpcclient/v6 and have all requests use RawRequest.

Originally posted by @chappjc in #838 (comment)

@amass01
Copy link
Member

amass01 commented Jan 22, 2021

will do

@chappjc
Copy link
Member Author

chappjc commented Jan 23, 2021

Only concern I'm having about the plan is we might make things harder on ourselves if/when we want to start using cfilters with bitcoind. i.e. https://github.com/btcsuite/btcd/blob/c3ece697dab966a9b8854facead71755d226eead/rpcclient/chain.go#L1235
But it doesn't look horrible - just keep using btcsuite's wire and btcjson packages, I believe. So not that we should stop this work, just putting that out there in case @buck54321 or @itswisdomagain have thoughts about this.

As an aside, I'm glad to see btcsuite "waking up" in the last several months, around May 2020 I guess. https://github.com/btcsuite/btcd/commits/master/rpcclient For a while I was a bit disheartened that without active maintainers it had stagnated, but I'm happy to see @jcvernaleo and friends keeping things moving.

@buck54321
Copy link
Member

#938 resolved this for the client, but the server still needs to be done. @amassarwi?

@buck54321 buck54321 reopened this Feb 10, 2021
@amass01
Copy link
Member

amass01 commented Feb 11, 2021

Oh right. will do the server part next of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants