Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update geth to at least 1.10.11 #1252

Closed
chappjc opened this issue Oct 25, 2021 · 2 comments · Fixed by #1257
Closed

update geth to at least 1.10.11 #1252

chappjc opened this issue Oct 25, 2021 · 2 comments · Fixed by #1257

Comments

@chappjc
Copy link
Member

chappjc commented Oct 25, 2021

I noticed that abigen from go-ethereum 1.10.10 is now generating a contract.go with breaking changes. The data has been reorganized, but it generates code for a version of the abi/bind package that apparently has breaking changes of its own.

A quick update of the require revealed other breaking changes. The main one that broke the build is that a node.Node no longer has account manager backends by default, requiring them to be registered. ethereum/go-ethereum#23019
This seems to require changes like:

- ks := node.AccountManager().Backends(keystore.KeyStoreType)[0].(*keystore.KeyStore)
+ ks := keystore.NewKeyStore(node.KeyStoreDir(), keystore.LightScryptN, keystore.LightScryptP)
+ node.AccountManager().AddBackend(ks)
@chappjc chappjc linked a pull request Oct 26, 2021 that will close this issue
@martonp
Copy link
Contributor

martonp commented Oct 27, 2021

@JoeGruffins Sorry if you were doing this, I didn't see the eyes there.

@JoeGruffins
Copy link
Member

@martonp no problems! I'll always make an issue first. Didn't notice I needed to update though, will do now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants