Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS Precision #40

Open
ttilberg opened this issue Feb 10, 2016 · 0 comments
Open

SASS Precision #40

ttilberg opened this issue Feb 10, 2016 · 0 comments

Comments

@ttilberg
Copy link
Contributor

Hello, I've been happily using this gem to get off the ground with Rails + Bootstrap.

I've come across an issue where a button is 1 pixel too small in height. I think I've traced it down to a SASS configuration thing related to SASS Number Precision.

image

https://github.com/twbs/bootstrap-sass#sass-number-precision

twbs/bootstrap-sass#595

I'm not fluent enough with Rails to understand how/where to monkeypatch this configuration change. If it's something that the gem could be conscious of during the bootstrap:install task (or wherever it needs to end up?), I think it would be relevant for all of your users.

If this is a simple configuration one-liner somewhere in config/ I'd love to know. I tried adding

::Sass::Script::Number.precision = [8, ::Sass::Script::Number.precision].max

to config/application.rb randomly, but it didn't do the trick. Probably because it's not what I needed to do ;)

Any tips are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant