Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pessimistic locking in budget #873

Closed
josepjaume opened this issue Feb 9, 2017 · 4 comments
Closed

Use pessimistic locking in budget #873

josepjaume opened this issue Feb 9, 2017 · 4 comments

Comments

@josepjaume
Copy link
Contributor

josepjaume commented Feb 9, 2017

🎩 User Story

We've found out that budgfets are vulnerable to going over the limits by clicking in multiple projects sequentially, very fast.

This should be tackled in two ways:

📋 Related documentation

None

🎯 Acceptance criteria

None

📌 Related issues

None

@andreslucena
Copy link
Member

andreslucena commented Feb 9, 2017

Duplicated #862 (although this one is better explained, so I'm closing the other one)

@josepjaume
Copy link
Contributor Author

Oh, sorry! Also, the two ways are compatible and should both be implemented.

@andreslucena
Copy link
Member

Also addno this validations on the javascript side.

@andreslucena andreslucena added type: bug Issues that describe a bug team: security labels Feb 9, 2017
@ghost ghost assigned josepjaume Feb 9, 2017
@ghost ghost added in-progress and removed type: bug Issues that describe a bug labels Feb 9, 2017
@josepjaume
Copy link
Contributor Author

That's not easy @andreslucena as we're storing the state on the DOM (using ujs). That would be manegeable using react but the app's achitecture can't currently hold it. Anyway, this will be transparent for the user as of #881

@ghost ghost removed the in-review label Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants