Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language file for FormBuilder is loaded from CDN #217

Closed
PierreMesure opened this issue Apr 12, 2023 · 5 comments · Fixed by #270
Closed

Language file for FormBuilder is loaded from CDN #217

PierreMesure opened this issue Apr 12, 2023 · 5 comments · Fixed by #270

Comments

@PierreMesure
Copy link

PierreMesure commented Apr 12, 2023

Describe the bug

For each page load of the platform (starting with the homepage), a call is made to the following address:
https://cdn.jsdelivr.net/npm/[email protected]/en-US.lang

It seems to come from this line of code.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the homepage
  2. Check the network tab of your Developer tools
  3. See error the faulty call

Expected behavior

This is an issue as with most CDN since they load their files from servers in third countries and are almost always American companies. In this specific case, my test returned Cloudflare and California. So not GDPR-friendly.

If needed, this file should be loaded from the server. It's only 3kb. It might also be an error since I'm not sure that specific file is needed at all time.

More info (please complete the following information):

  • Decidim 0.26.5
  • Decidim Awesome 0.9.1
  • Example instance: escolaipau.org
@microstudi
Copy link
Contributor

Yeah, I can see the value on have all the downloads in-house but, honestly I don't see it as a big deal.

Can you elaborate why is not GDPR friendly? It is not using cookies or moving data in any sense...

@PierreMesure
Copy link
Author

PierreMesure commented Apr 12, 2023

Not sure how detailed I should be, do you know about the Schrems II judgement? Since IP adress is PII, even a minimal service such as a CDN can be used to track people and we know since Snowden that the US government does that in a systematic way. So all these services are forbidden if they are owned by a US-based company according to GDPR: Google Fonts, Cloudflare, etc...

@froger
Copy link
Contributor

froger commented Apr 12, 2023

Hello, seems there is a config to load language files from local. I guess we could add the files in the public directory and define the formbuilder config i18n.location.

https://github.com/kevinchappell/formBuilder/blob/902206505760b8af8417f479a4ddcdc641c46b10/docs/development.md#languages

@microstudi
Copy link
Contributor

Hello, seems there is a config to load language files from local. I guess we could add the files in the public directory and define the formbuilder config i18n.location.

https://github.com/kevinchappell/formBuilder/blob/902206505760b8af8417f479a4ddcdc641c46b10/docs/development.md#languages

I'm sure it isn't much difficult to do this. PRs welcomed!

@PierreMesure
Copy link
Author

PierreMesure commented Apr 18, 2023

Happy to send it, but I'm unsure where to add these .lang files. Maybe public/formbuilder/lang? I could also add this as a submodule linking directly to this repo.

@microstudi microstudi linked a pull request Mar 21, 2024 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants