Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a consistent result from signature verification methods #155

Open
frankhinek opened this issue May 3, 2024 · 0 comments
Open

Return a consistent result from signature verification methods #155

frankhinek opened this issue May 3, 2024 · 0 comments
Labels
crypto cryptographic primitives discuss testing related to new or existing tests

Comments

@frankhinek
Copy link
Contributor

Context

At present, signature verification is handled inconsistently across Web5 SDKs:

  • JS and Go return a boolean false if a signature isn't valid
  • Dart and Kotlin raise an exception

The associated test vectors for ES256K/secp256k1 and Ed25519 indicate that a boolean false should be returned and that no error should be raised/returned.

Work to be done

  1. Come to a decision on whether a boolean or error raise should occur when a signature fails the verification check.
  2. Update the associated test vectors.
  3. Update the SDKs that need to be modified accordingly.
  4. Ensure all SDKs pass the test vectors.
@frankhinek frankhinek added testing related to new or existing tests discuss crypto cryptographic primitives labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto cryptographic primitives discuss testing related to new or existing tests
Projects
None yet
Development

No branches or pull requests

1 participant