Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DidKeyResolver and DidIonResolver generate not used in web5 #38

Closed
jdutchak opened this issue Apr 14, 2023 · 1 comment
Closed

DidKeyResolver and DidIonResolver generate not used in web5 #38

jdutchak opened this issue Apr 14, 2023 · 1 comment
Assignees
@frankhinek
Labels
question Further information is requested

Comments

@jdutchak
Copy link

Curious why the DidKeyResolver and DidIonResolver generate() method was not used in web5 vs adding the ion tool again and using tweetnacl for key method?

It seems importing creation of DIDs using the dwn-sdk-js would be a smoother implementation ??
@frankhinek frankhinek self-assigned this Apr 14, 2023
@frankhinek frankhinek added the question Further information is requested label Apr 14, 2023
@frankhinek
Copy link
Contributor

Hey @jdutchak - Good question. No particular reason other than it hadn't yet been addressed yet.

Resolved in PR #37
https://github.com/TBD54566975/web5-js/blob/786f1820986a30a81376a34d7013dfdd3e6c15c4/src/did/methods/ion.js#L2
https://github.com/TBD54566975/web5-js/blob/786f1820986a30a81376a34d7013dfdd3e6c15c4/src/did/methods/key.js#L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankhinek frankhinek

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frankhinek @jdutchak