Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate replacing multiformats with scure-base #153

Open
frankhinek opened this issue Jul 10, 2023 · 0 comments
Open

Evaluate replacing multiformats with scure-base #153

frankhinek opened this issue Jul 10, 2023 · 0 comments

Comments

@frankhinek
Copy link
Contributor

frankhinek commented Jul 10, 2023 •
edited
Loading

https://github.com/TBD54566975/web5-js/blob/b6db3c843a04bdd0a06a773a02774695fa97ddc4/packages/common/src/convert.ts#L3-L4

thoughts on using paulmillr's scure-base for base encoding? makes sense to use multiformats given that we've already pulled it in as a dependency. if we do decide to switch to scure-base we'll want to use base64urlnopad (context)

Originally posted by @mistermoe in #152 (comment)
@frankhinek frankhinek changed the title thoughts on using paulmillr's [scure-base](https://github.com/paulmillr/scure-base) for base encoding? makes sense to use multiformats given that we've already pulled it in as a dependency. if we do decide to switch to scure-base we'll want to use base64urlnopad ([context](https://github.com/paulmillr/scure-base/issues/4)) Evaluate replacing multiformats with scure-base Jul 10, 2023
@frankhinek frankhinek mentioned this issue Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frankhinek