Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] export createJWK #1325

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented Jan 24, 2024

What issue is this PR fixing

Fixes #1324

What is being changed

Exports createJWK function from utils package

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ac343e) 85.50% compared to head (ec3fdd8) 85.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1325   +/-   ##
=======================================
  Coverage   85.50%   85.51%           
=======================================
  Files         170      170           
  Lines       18947    18947           
  Branches     2120     2120           
=======================================
+ Hits        16201    16202    +1     
+ Misses       2746     2745    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mirceanis mirceanis merged commit 610ee66 into decentralized-identity:next Jan 24, 2024
9 checks passed
@cre8 cre8 deleted the cre8/issue1324 branch January 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] export createJWK
4 participants