Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify whether the constraints property should be mandatory #472

Closed
decentralgabe opened this issue Mar 12, 2024 · 4 comments
Closed

Clarify whether the constraints property should be mandatory #472

decentralgabe opened this issue Mar 12, 2024 · 4 comments
Assignees
Milestone

Comments

@decentralgabe
Copy link
Member

The constraints property in input descriptors is mandatory; however, all properties in the property are optional. This seems to introduce a case which necessitates an empty constraints property exists.

Should the language be updated to....

  1. Make constraints optional (what's the use case - just checking for format?)
  2. Keep constraints required and specify that at least one sub-property must be present
@kimdhamilton
Copy link
Collaborator

kimdhamilton commented Mar 14, 2024

Making this MAY -> does input_descriptors need to be MAY?

@kimdhamilton kimdhamilton added the bug Something isn't working label Mar 14, 2024
@kimdhamilton kimdhamilton added this to the v2.1 milestone Mar 14, 2024
@kimdhamilton kimdhamilton removed the bug Something isn't working label Mar 14, 2024
@decentralgabe
Copy link
Member Author

@kimdhamilton no - since there is value on selecting a credential on format along (from @Sakurann)

@dif-admin
Copy link
Member

We need to add format to input evaluation

@dif-admin
Copy link
Member

Decision from 3/21: Keep it MUST, clarify in input evaluation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants