Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONPath/Pointer changes for 2.1 #456

Open
kimdhamilton opened this issue Nov 2, 2023 · 5 comments
Open

JSONPath/Pointer changes for 2.1 #456

kimdhamilton opened this issue Nov 2, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kimdhamilton
Copy link
Collaborator

Concerns

  • JSONPath: security issues
  • 2.1 breaking change

Structure of PE spec

  • base: simple stuff
  • features: advanced, under-defined

Structurally better to have jsonpointer at the base layer, but breaking change

Decision:

  • Add a new pointer property at same level of path. Strong preference for this in implementation notes
  • Soft launch with preference for jsonpointer that falls back to jsonpath
  • In 3.0, path becomes a feature
@kimdhamilton kimdhamilton added the enhancement New feature or request label Nov 2, 2023
@kimdhamilton kimdhamilton added this to the v2.1 milestone Nov 2, 2023
@pmhsfelix
Copy link

What does it mean In 3.0, path becomes a feature?

@colbyharrison
Copy link

I believe this means that in the 3.0 release Json Path will become an extension on the spec and not required to be conformant with the spec. See: https://identity.foundation/presentation-exchange/#structure-of-this-document

@OR13
Copy link
Contributor

OR13 commented Feb 29, 2024

You should update your references to this nice shiny new RFC:

https://datatracker.ietf.org/doc/html/rfc9535

@kimdhamilton
Copy link
Collaborator Author

So shiny, thanks!

@Sakurann
Copy link
Contributor

Sakurann commented Mar 1, 2024

as discussed in openid/OpenID4VCI#266, even JSON Pointer might not meet all the requirements like indexing array entries. alternative mechanism could be something like proposed here: openid/OpenID4VCI#276

@kimdhamilton kimdhamilton modified the milestones: v2.1, future Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants