fix: dont mark a partially synced transaction as synced

decentralized-identity · Dec 12, 2019 · 698dab0 · 698dab0
1 parent e7ebf0a
commit 698dab0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/element-lib/src/sidetree-v2/func.js b/packages/element-lib/src/sidetree-v2/func.js
@@ -94,6 +94,9 @@ const syncTransaction = async (sidetree, transaction, onlyDidUniqueSuffix = null
       writeOperationToCache,
       filteredOperationByDidUniqueSuffixes,
     ).then(() => {
+      if (operationsByDidUniqueSuffixes.length !== filteredOperationByDidUniqueSuffixes.length) {
+        return null;
+      }
       return sidetree.db.write(`transaction:${transaction.transactionNumber}`, {
         type: 'transaction',
         ...transaction,

diff --git a/packages/element-lib/src/sidetree-v2/protocol/resolve.spec.js b/packages/element-lib/src/sidetree-v2/protocol/resolve.spec.js
@@ -415,5 +415,12 @@ describe.only('resolve just in time', () => {
       const cachedTransactions = await sidetree.db.readCollection('transaction');
       expect(cachedTransactions).toHaveLength(0);
     });
+
+    it('should fully synced transaction if did is the only suffix in the batch', async () => {
+      const didDocument = await resolve(sidetree)(didUniqueSuffix3, true);
+      expect(didDocument.id).toContain(didUniqueSuffix3);
+      const cachedTransactions = await sidetree.db.readCollection('transaction');
+      expect(cachedTransactions).toHaveLength(1);
+    });
   });
 });