Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eslint sort-imports rule with prettier plugin #57

Closed
adam4leos opened this issue Sep 12, 2023 · 8 comments · Fixed by #74
Closed

Replace eslint sort-imports rule with prettier plugin #57

adam4leos opened this issue Sep 12, 2023 · 8 comments · Fixed by #74
Assignees
Labels
good first issue Good for newcomers hacktoberfest For the hacking month of October help wanted Extra attention is needed

Comments

@adam4leos
Copy link
Contributor

adam4leos commented Sep 12, 2023

Background:

Replace eslint sort-imports rule with prettier plugin

Task Details:

currently we have an eslint rule supporting sort-imports rule.

'sort-imports': [
      'error',
      {
        ignoreCase: true,
        ignoreDeclarationSort: false,
        ignoreMemberSort: false,
        memberSyntaxSortOrder: ['none', 'all', 'single', 'multiple'],
        allowSeparatedGroups: true,
      },
    ],

Picking Up This Issue:

  • If you'd like to work on this, please comment "picking this up" below, and I'll assign the issue to you

Questions:

Resources:

  • Creating a Pull Request: If you're new to GitHub and unsure how to create a pull request, follow this step-by-step guide.

Remember, communication is key! If you have any questions or face any challenges, we're here to help so please don't hesitate to reach out.

Good Luck! 🍁

@adam4leos adam4leos added good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest For the hacking month of October labels Sep 12, 2023
@Opssy
Copy link

Opssy commented Sep 13, 2023

@adam4leos I need more clearification

@adam4leos
Copy link
Contributor Author

@Opssy currently we have an eslint rule supporting sort-imports rule.

'sort-imports': [
      'error',
      {
        ignoreCase: true,
        ignoreDeclarationSort: false,
        ignoreMemberSort: false,
        memberSyntaxSortOrder: ['none', 'all', 'single', 'multiple'],
        allowSeparatedGroups: true,
      },
    ],

We'd like to remove this rule from eslint and instead use plugin for prettier, possibly https://github.com/trivago/prettier-plugin-sort-imports
to match the eslint rule as close as possible atm

@Opssy
Copy link

Opssy commented Sep 14, 2023

okay

@EbonyLouis
Copy link
Contributor

@Opssy Hi, is this an issue you'd like to work on for Hacktoberfest?

@Opssy
Copy link

Opssy commented Sep 26, 2023

@EbonyLouis
Yes

@EbonyLouis
Copy link
Contributor

@Opssy yay! its been assigned to you.

I'd also like to note that Hacktoberfest officially kicks off on October 1st. Contributions made before the event may not be eligible for the challenge. However, feel free to start working on it, but I'd recommend holding off on submitting your PR until the event begins.

to be eligible for Hacktoberfest's official prizes make sure you're registered, registration is now open! Reach out if you need any help 🥳

@jerempy
Copy link
Contributor

jerempy commented Oct 16, 2023

picked it up since it looks like 3 weeks with no activity. PR linked above

@EbonyLouis
Copy link
Contributor

@jerempy thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest For the hacking month of October help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants