Validate protocol definition upon ingestion

[diehuxx]

Currently we don't do any validation of a protocol definition within ProtocolsConfigure before we store the definition. There are a few things we can check to validate that the protocol definition isn't broken before we try to write records to it.

1. Validate that the protocolPath in a given rule set is not longer than the ancestor path to reach that rule set. Currently we check this upon Records* handling here
2. As we refactor towards Revisit protocol definition schema style and consider adopting a style with predefined property names #326, we will need to validate that
   a. no two recordTypes have the same id
   b. no two descendants in a given ruleset have the same recordType

[thehenrytsai]

@diehuxx, just want to sanity check so I understanding the issue fully: I am pretty sure we do validation for the protocol definition within ProtocolsConfigure during parse() before we store the definition as well as during create(). You were modifying the schema for it, so I don't fully understand, can you clarify?

Agree that we can and should do more validation beyond basic JSON Schema, especially if we revamp the protocol definition schema, but this is true in general to all DWN message types.

[diehuxx]

Agree that we can and should do more validation beyond basic JSON Schema, especially if we revamp the protocol definition schema, but this is true in general to all DWN message types.

Yep this is what I meant. Sorry, should have been more clear in the description! We definitely do JSON schema validation, which covers a lot of what we need. But there's a few more validations (like those listed in the description) that we need to add to the code, or I need to figure out how to do those checks within JSON schema.

[thehenrytsai]

We have revamped the protocol definition its code quite drastically, this is no longer relevant.