chore: remove dev dependency did-key-creator #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nickreynolds
commented
Mar 15, 2023
nickreynolds
commented
- this dev dependency was bringing in versions of multiformats / multicodec that may be causing issues in other projects
- it's easiest to just remove this dependency and hardcode the values it was generating, rather than sorting out all dependency issues across multiple repos
nickreynolds
commented
Mar 15, 2023
| @@ -121,151 +120,156 @@ const audDidDoc = { | |||
|
|
|||
| describe('createJWT()', () => { | |||
| describe('ES256', () => { | |||
| const alg = 'ES256' | |||
There was a problem hiding this comment.
this is just whitespace changes
nickreynolds
commented
Mar 15, 2023
| // const multicodecName = 'p256-pub'; | ||
| // const publicKey = '0314c58e581c7656ba153195669fe4ce53ff78dd5ede60a4039771a90c58cb41de' | ||
| // const did = encodeDIDfromHexString(multicodecName,publicKey) | ||
| const did = 'did:key:zDnaej4NHntda4rNW4FBUJgFzdcgEAXKGRVGE8LuVfRbuMuc1' |
There was a problem hiding this comment.
this is the actual change
mirceanis
approved these changes
Mar 15, 2023
uport-automation-bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
## [6.11.3](6.11.2...6.11.3) (2023-03-15) ### Bug Fixes * **deps:** remove dev dependency did-key-creator ([#274](#274)) ([fbe09e1](fbe09e1))
|
🎉 This PR is included in version 6.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.