Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VerifierAlgorithm for ES256 #249

Merged
merged 60 commits into from
Sep 6, 2022
Merged

Add VerifierAlgorithm for ES256 #249

merged 60 commits into from
Sep 6, 2022

Conversation

bshambaugh
Copy link
Contributor

@bshambaugh bshambaugh commented Sep 2, 2022 •
edited
Loading

This is the answer to:
#248 (review)

Update VerifierAlgorithm.ts for ES256.

Update VerifierAlgorithm.test.ts for ES256.

I had to re-declare some variables locally for ES256. Is it appropriate to move some globally declared variables for ES256K and ed25519 or just leave them?

@bshambaugh
add ES256Signer Module
aaedaf5
@bshambaugh
update base58 test, it appears to have a problem
ae80a5a
@bshambaugh
update with failing test for base58
52646fd
@bshambaugh
modify base58matcher to match both base58 in es256 and es256k
ac8e814
@bshambaugh
change 68 to 86 in base58 matcher
27fd5ea
@bshambaugh
remove uneccessary = sign in the base64 regex
3835342
@bshambaugh
add ES256Signer to index so it is acessible
7c26c1a
@bshambaugh
refactor SignerAlgorithm.ts and SignerAlgorithm.test.ts by breaking u…
333fa55 
…p into files by curve
@bshambaugh
move tests for signers into folder called signers
f9ed034
@bshambaugh
remove carriage returns (should be result of enter) and unused variab…
85a5cbc 
…les as suggested by linter
@bshambaugh
break up verifierAlgorithm into separate files bases on Curve
ac795f0
@bshambaugh
add preliminary tests for JWT
9d108ad
@bshambaugh
refactor VerifierAlgorithm test
635eb7e
@bshambaugh
update JWT tests
622a7d1
@bshambaugh
update ES256Signer with constants
62e6f7d
@bshambaugh
change the name of constants to common in JWT test folder
dcdeeb5
@bshambaugh
add tests for JWT common
e498f41
@bshambaugh
add ES256 to Signer Verifier and JWT ...tests needed
d8dccf9
@bshambaugh
add note about supported key types in JWT, Signer, and Verifier Algor…
61e9928 
…ithms, add a not for secp256r1 support of in src/VerifierAlgorithm.common.ts
@bshambaugh
in common_Signer_test_test.ts the create JWK functions need to be tes…
20c1ebe 
…ted for u8a, temporarily commiting for now
@bshambaugh
added test to for comosmos adress from public key to keep consistent …
8b18d4e 
…through changes
@bshambaugh
commit stub for decrypt / encrypt JWE Decrypter impl. for P-256
0c1c1fd
@bshambaugh
reverse base64matcher to original version that will match '=' sign, o…
f312794 
…pen up issue
@bshambaugh
add a second matcher for base58 to util.test.ts to illustrate variabl…
8a38d4c 
…e length issue
@bshambaugh
remove encrypters and clean up to remote forks state
027f701
@bshambaugh
update util.ts with latest matcher
f39c88e
@bshambaugh
util.ts to fork
92e2bff
@bshambaugh
util.ts to fork try 2
6dcb134
@bshambaugh
reset util.test.ts to fork
9c0b48b
@bshambaugh
remove cosmos test because it is not upstream
a0cd2a2
@bshambaugh
update package.json to match upstream
28f04a7
@bshambaugh
update package.json to match upstream try 2
17cba29
@bshambaugh
add JWT.test.ts.snap
c0b2791 
to match upstream
@bshambaugh
add yarn.lock to match upstream
ca8a2e8
@bshambaugh
remove parseKey from Signers as well as base64, 58, and hex matchers
129f566
@bshambaugh
remove commented out code with ES256KSigner.test.ts
b4fc0e2
@bshambaugh
update README and export functions that convert hex, base64, and base…
9e4e33e 
…58 to bytes
@bshambaugh
fix documentation for ES256KSigner
dbf34ef
@bshambaugh
Merge remote-tracking branch 'upstream/master'
a2c7e6a
@bshambaugh
remove extra line at the end of the files
fa61104
@bshambaugh
add newline to each of the files
a97d6a9
@bshambaugh
create a ES256Signer
a3b8fb4
@bshambaugh
Add ES256Signer Tests
4e0a669
@bshambaugh
update fixes suggested by linter
5b0cecf
@bshambaugh
removed recoverable parameter from ES256Signer since only recoverable…
169e7bd 
… with secp256k1 not secp256r1
@bshambaugh
add code specific to ES256 and P-256 to SignerAlgorithm.ts
7b02c56
@bshambaugh
created files for verifieralgorithm.ts, tests do not pass..merge with…
636de24 
… signer alg code
@bshambaugh
Merge branch 'addES256VerifierAlg' into addES256SignerandVeriferAlg
b06fca3
@bshambaugh
move signer declaration to match interface
3a4e4bc
@bshambaugh
fix merge conflict with ES256Signer and test
c789049
@bshambaugh
Merge branch 'master' into addES256SignerandVeriferAlg
e8b46a2
@bshambaugh
update verifieralgorithm and tests with ES256
d73bd52
@bshambaugh
Merge branch 'master' of github.com:bshambaugh/did-jwt
c7ab289
@bshambaugh
Copy link
Contributor Author

I should note that I am making progress with JWT.ts and JWT.test.ts. This may be relevant to the VerifierAlgorithm.ts. Maybe we should wait for that?

mirceanis
mirceanis approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the contribution!

@mirceanis
Copy link
Member

I had to re-declare some variables locally for ES256. Is it appropriate to move some globally declared variables for ES256K and ed25519 or just leave them?

Don't concern yourself too much with refactoring. While that is very important, I'd like to separate any refactoring changes from feature implementations.

If you do want to contribute refactoring PRs, please separate code-refactoring-PRs from test-refactoring-PRs to ease the review.

Thank you for coming back with small PRs, it makes this process so much easier!

@mirceanis mirceanis merged commit 05283ac into decentralized-identity:master Sep 6, 2022
uport-automation-bot pushed a commit that referenced this pull request Sep 6, 2022
@semantic-release-bot
chore(release): 6.8.0 [skip ci]
86010a6 
# [6.8.0](6.7.0...6.8.0) (2022-09-06)

### Features

* add VerifierAlgorithm for ES256 ([#249](#249)) ([05283ac](05283ac))
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 6.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshambaugh @mirceanis @uport-automation-bot