Remove parseKey, change ES256K and Ed25519 signers to Uint8Array only #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p into files by curve
…les as suggested by linter
…ithms, add a not for secp256r1 support of in src/VerifierAlgorithm.common.ts
…ted for u8a, temporarily commiting for now
to match upstream
|
This looks good! Very nice work! |
mirceanis
approved these changes
Apr 4, 2022
uport-automation-bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
# [6.0.0](5.12.4...6.0.0) (2022-04-04) ### Bug Fixes * remove parseKey, change ES256K and Ed25519 signers to Uint8Array only ([#224](#224)) ([9132caf](9132caf)), closes [#222](#222) ### BREAKING CHANGES * The Signer classes exported by this library no longer accept private keys with string encodings, only `Uint8Array`. This reduces the potential ambiguity between different formats. Some utility methods are exported that allow users to convert some popular encodings to raw `Uint8Array`.
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to create a fix for:
#222