Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for authenticated encryption #177

Merged
merged 9 commits into from
May 31, 2021
Merged

Added support for authenticated encryption #177

merged 9 commits into from
May 31, 2021

Conversation

awoie
Copy link
Member

@awoie awoie commented May 25, 2021

Added ECDH-1PU+XC20PKW, AuthEncrypter/Decrypter and AnonEncrypter/Decrypter

@awoie awoie changed the title Added support for authenticated encryptioin Added support for authenticated encryption May 25, 2021
@awoie awoie requested a review from mirceanis May 25, 2021 10:45
@awoie
Copy link
Member Author

awoie commented May 25, 2021

@oed pls review again

mirceanis
mirceanis approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

mirceanis
mirceanis requested changes May 28, 2021
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-reviewed and noticed some things.
I added some suggestions for what could be slightly better names for some methods and a reminder to also export the new methods in index.ts

src/xc20pEncryption.ts Outdated Show resolved Hide resolved
src/xc20pEncryption.ts Outdated Show resolved Hide resolved
src/xc20pEncryption.ts Outdated Show resolved Hide resolved
src/xc20pEncryption.ts Outdated Show resolved Hide resolved
@mirceanis mirceanis mentioned this pull request May 28, 2021
Closed
@awoie awoie requested a review from mirceanis May 28, 2021 14:34
mirceanis
mirceanis approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

oed
oed approved these changes May 29, 2021
View reviewed changes
Copy link
Contributor

@oed oed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Would be nice to have Some API documentation for the JWE stuff though!

@mirceanis mirceanis merged commit 9a71b07 into master May 31, 2021
@mirceanis mirceanis deleted the awoie/add-ecdh-1pu branch May 31, 2021 09:48
uport-automation-bot pushed a commit that referenced this pull request May 31, 2021
@semantic-release-bot
chore(release): 5.5.0 [skip ci]
99b4c23 
# [5.5.0](5.4.1...5.5.0) (2021-05-31)

### Features

* Add support for authenticated encryption ([#177](#177)) ([9a71b07](9a71b07))
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 5.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oed oed oed approved these changes

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awoie @uport-automation-bot @mirceanis @oed