feat!: Upgrade did-resolver to v3 #151
Conversation
src/xc20pEncryption.ts
Outdated
| if (typeof key === 'string') { | ||
| return didDoc.publicKey.find((pk) => pk.id === key) | ||
| return didDocument.verificationMethod.find((pk) => pk.id === key) |
There was a problem hiding this comment.
Some resolvers may still be using the deprecated publicKey member of the DIDDocument.
I think the 2 arrays should be merged, to support these resolvers.
Perhaps something like this would do the trick:
| return didDocument.verificationMethod.find((pk) => pk.id === key) | |
| return ([ | |
| ...(didDocument.publicKey), | |
| ...(didDocument.verificationMethod) | |
| ].find((pk) => pk.id === key) |
I see that a similar approach is used in JWT.ts#resolveAuthenticator() but that one has some extra checks.
There was a problem hiding this comment.
Nice catch. I believe I did this elsewhere in the code.
src/VerifierAlgorithm.ts
Outdated
| if (pk.publicKeyBase58) { | ||
| return base58ToBytes(pk.publicKeyBase58) | ||
| } else if (pk.publicKeyBase64) { | ||
| } else if (isLegacyVerMethod(pk) && pk.publicKeyBase64) { |
There was a problem hiding this comment.
is this extra check necessary?
Perhaps it can be simplified to something like:
| } else if (isLegacyVerMethod(pk) && pk.publicKeyBase64) { | |
| } else if ((<LegacyVerificationMethod>pk).publicKeyBase64) { |
src/JWT.ts
Outdated
| const authenticators: PublicKey[] = publicKeysToCheck.filter(({ type }) => | ||
| types.find((supported) => supported === type) | ||
| const authenticators: VerificationMethod[] = publicKeysToCheck.filter(({ type }) => | ||
| types.indexOf(type) !== -1 |
There was a problem hiding this comment.
Why is the filter for supported types removed?
There was a problem hiding this comment.
That's actually the same logic. This change is not needed, can change it back.
|
Pushed some edits to address your comments @mirceanis |
# [5.0.0](4.9.0...5.0.0) (2021-03-09) ### Features * upgrade did-resolver to v3 ([#151](#151)) ([e02f56b](e02f56b)) ### BREAKING CHANGES * The `Resolver` used during verification is expected to conform to the latest spec.
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Replaces #150
Fixes #144
Edit:
I think this would be seen as a breaking release so I flagged it as such.