fix: remove signed fetch origin & referer #2905
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Whenever we attempt to set these values explicitly LIBCURL throws the following errors:
Digging deeper it was introduced due to a specific server side check here which effectively means we are forced to "spoof" the origin rather than let the library manage the origin itself (for security purposes).
No other endpoints should reject based on origin in this way, so it should be fixed server side to ensure the guestbook works in Goerli. The CORS policies should be setup server side to ensure security to avoid CSRF attacks and allow for localhost requests but not cross-origin.
How to test the changes?
NOTE: Guestbook will no longer work
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md