Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: "Missing" settings.tdb should be ignored #72

Closed
jeffsf opened this issue Feb 23, 2021 · 2 comments
Closed

plugins: "Missing" settings.tdb should be ignored #72

jeffsf opened this issue Feb 23, 2021 · 2 comments

Comments

@jeffsf
Copy link
Contributor

jeffsf commented Feb 23, 2021

It should not be an error that settings.tbd is missing as all plugins do not have settings.

error opening binary file: path/to/de1plus/plugins/jmk_hacks/settings.tdb / 'couldn't open "path/to/de1plus/plugins/jmk_hacks/settings.tdb": no such file or directory' / '1' / 
Settings file: 
@ebengoechea
Copy link
Collaborator

@jeffsf I corrected that in my last plugins PR, as DGUI doesn't have settings either, are you testing with the latest beta?

@jeffsf
Copy link
Contributor Author

jeffsf commented Feb 23, 2021

Commit 0125113 yes?

I'll rebase

Edit: Rebased on tag v1.34.13 seems to have resolved at least that message, though there are other plugin issues arising now including:

  • Dependency in core code to load without wibble present. This is likely a structural problem with the web_api plugin, as wibble shouldn't be required if the webserver is disabled and isn't going to be run (package require should be in initialization code or otherwise separated from loading and retrieval of metadata). plugins: web_api: package require wibble causes errors, even if not enabled #73
  • Problems loading a custom plugin reported as "can't read "plugin_name", no such variable

Leaving open at this time until I can verify by removing the offending, upstream plugins.

Closing as resolved on or before tag v1.34.13

@jeffsf jeffsf closed this as completed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants