-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arcs on dselector are too thin #246
Comments
@decentjohn Are the captures from tablet or PC/Mac? The corners are coded to have one pixel less than the sides, intentionally, because this is how they looked best when using thin borders on my Teclast tablet. Having them the same width showed them too wide, not matching the sides lines. But this was different on my PC (which was better when using the same width for sides and corners), so I prioritized the tablet case. It is my suspicion also that this may depend on the specific width values being even or odd in the target resolution, as they are specified in a bigger resolution and then rescaled. So, rounding may produce different results in different resolutions. |
Could you look at the arcs on your tablet again, and see if they indeed do seem right on your teclast tablet or too thin? I have the patch above to +1 the thickness, but it sounds like where I put the change is suboptimal, as you -1 it somewhere else? |
@decentjohn
|
I haven't committed my change, as I was waiting until we settled our conversation. I will switch to your method for this. |
@decentjohn Is that capture from your tablet? |
Not possible as far as I know. It seems the problems arise from different dithering behaviour between lines and arcs, and between platforms (PC/Mac/Android), but it is automatic, there's no argument for controlling it on canvas elements. |
As an aside, we probably should decide on default colors to use for the dui buttons and use them in a consistent way. I'm fine with "blue=tappable" as you have done with "Use default color" |
The left and right arcs are slightly too thin.
I think this is simply how Tk draws them, compared to vertical/horizontal lines.
One fix is to add +1 to the width of the arcs:
You can see how this looks if I change just one part of the arc:
doing it to the 4 arcs fixes the appearance:
I noticed that even when I drew with a thicker -width, the arcs were still off by one:
I'm not sure if this is how you want this fixed, or prefer another method?
The text was updated successfully, but these errors were encountered: