Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding Bulma variables does not work #87

Closed
paulgrieselhuber opened this issue Jul 4, 2018 · 6 comments
Closed

Overriding Bulma variables does not work #87

paulgrieselhuber opened this issue Jul 4, 2018 · 6 comments

Comments

@paulgrieselhuber
Copy link

In src/layouts/all.scss, adding, for instance $navbar-padding-horizontal: 15rem on either line 1 or 2 (or anywhere really), before or after @import "~bulma/sass/utilities/initial-variables" does nothing.

According to the Bulma docs, this should be the correct way to override Bulma variables.

@paulgrieselhuber
Copy link
Author

Would also appreciate any info here.

@AustinGreen
Copy link
Contributor

If you're still early on in your project, I would recommend switching from Bulma to a react component library. #57 proposed this change, but I felt it was unnecessary for a template project. After using https://react.semantic-ui.com/ in production for a few months, I've completely changed my mind.

Future versions will make this change. I can investigate your specific issue with Bulma if this is not what you were looking for, but I think the root of the problem is that you need a proper react-based UI library with built-in theming.

@paulgrieselhuber
Copy link
Author

Thanks for the feedback. Regarding future versions making this change, does this include the gatsby-v2 branch?

@erquhart
Copy link
Contributor

That branch will eventually be merged into master, so yes.

@simoneduca
Copy link

simoneduca commented Nov 6, 2018

@paulisloud, FWIW I had the same issue and the cause was two different import Bulma statements, one at the top and one at the bottom of the file. Once I only had @import "~bulma" at the top of file I was able to override Bulma as expected. Happy to open a PR if that solves it for you.

@ZoltanVeres
Copy link
Collaborator

I don't think this is an issue anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants